refactor(gui): stabilize model feedback callback dependencies by yansigit · Pull Request #3984 · lidge-jun/opencodex

yansigit · 2026-09-08T01:11:11Z

Summary

Wrap the setter-only feedback publisher in useCallback and include it in the display-name save callback dependencies. This makes the callback contract explicit without changing displayed feedback or save behavior.

No user-facing behavior change; existing documentation remains accurate. Screenshot shows the verified existing editor.

Verification

Root bun run typecheck, GUI bun run lint, and bun run build passed. GUI tests: 1921 passed, zero failures. Browser verification saved and reopened a friendly name using synthetic API data.

All runtime checks used a fresh temporary OPENCODEX_HOME and alternate port; production config fingerprint and backup inventory remained unchanged. Full root-suite and review-readiness gates have not been completed for this head; this is intentionally a draft.

Checklist

Scope stays focused and avoids unrelated cleanup.
Added/updated regression coverage or verified existing coverage for the affected behavior.
Docs or release notes were updated when needed.
Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Review readiness

Local CI green.
Branch on the latest dev commit.
All correct Codex and CodeRabbit findings fixed.
Ready-for-review confirmation.

Co-authored-by: SB Yoon 44089734+yansigit@users.noreply.github.com
Co-authored-by: Yumi automation@sbyoon.com

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

All CI tests are green on my local testing.
I pushed my PR to the latest dev commit.
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.

Extracted and adapted from fork commit 4d36c91. Co-authored-by: Yumi <automation@sbyoon.com>

coderabbitai · 2026-09-08T01:11:19Z

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-08T01:29:32Z

⚠️ Deterministic hygiene checks failed.

missing_regression_test — Behavior changed under src/ or gui/src/ without a test change. Add focused coverage or obtain test-exception-approved.

github-actions · 2026-09-08T01:30:49Z

⏳ DRAFT

hygiene: missing_regression_test.

What to do

Fix missing_regression_test — Behavior changed under src/ or gui/src/ without a test change. Add focused coverage or obtain test-exception-approved.
Tick all four boxes in the PR description once you're done (currently 0/4).

Review readiness checklist

⬜ All CI tests are green on my local testing.
⬜ I pushed my PR to the latest dev commit.
⬜ I resolved all correct Codex and CodeRabbit findings.
⬜ My PR is ready for review.

0/4 boxes ticked.

This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.
@yansigit Tick the boxes once your local CI is green, your branch is on the latest dev commit, and every correct Codex and CodeRabbit finding is resolved.

Hygiene

⚠️ Deterministic hygiene checks failed.

missing_regression_test — Behavior changed under src/ or gui/src/ without a test change. Add focused coverage or obtain test-exception-approved.

lidge-jun · 2026-09-08T01:49:04Z

리뷰 · 우선순위 36 / 80

이 PR은 gui/src/pages/Models.tsx에서 publishFeedback을 useCallback으로 감싸고, saveDisplayName effect 의존성 배열에 넣습니다. 의도 설명은 분명합니다. toast generation(feedbackGen)을 올리는 함수가 매 렌더마다 새 참조면, 그걸 dep에 넣은 effect가 불필요하게 다시 돌 수 있다는 이야기입니다. 지금 dev HEAD c15662855의 같은 파일 721–731행 근처에는 이미 반대 방향의 주석이 있습니다. plain async loader를 useCallback으로 감싸 exhaustive-deps를 채우면 PreserveManualMemo·Immutability·EffectSetState 경고가 한 개에서 다섯 개로 늘어난다고 2026-08-27에 검증해 두었고, gui/.oxlintrc.json / gui/doctor.config.json으로 이 파일 규칙을 눌러 둔 상태입니다. 그래서 “dep를 채우려고 useCallback을 추가한다”는 이 PR의 방향이, 파일에 이미 적은 react-compiler hygiene과 충돌할 여지가 큽니다. 게이트도 이미 intake: hygiene-blocked이고, hygiene 봇이 missing_regression_test(gui/src/ 동작 변경인데 테스트 없음)로 막았습니다. 스크린샷 바이너리만 추가됐고 회귀 테스트는 없습니다. types/config 분할과 무관합니다.

라인 gui/src/pages/Models.tsx · publishFeedback useCallback - 빈 deps []로 감쌉니다. setState만 쓰니 참조 안정화 자체는 맞지만, 이 파일의 PreserveManualMemo 예외 전략과 같은 패턴인지 먼저 확인해야 합니다.
라인 gui/src/pages/Models.tsx · saveDisplayName deps - publishFeedback을 배열에 추가합니다. 함수를 안정화하지 않은 채 넣으면 effect churn이 생기고, 안정화하면 compiler 경고 표면이 늘 수 있습니다.
경로 intake: hygiene-blocked / missing_regression_test - GUI 동작 변경인데 테스트가 없습니다. test-exception-approved 또는 Models toast/feedback 포커스 테스트가 필요합니다.
경로 assets/pr-screenshots/model-feedback-review.png - 시각 증거는 있으나 hygiene의 regression-test 요구를 대체하지 않습니다.
경로 enforce-target - 현재 fail입니다. draft 체크리스트도 0/4입니다.

메인테이너의 판단이 필요한 지점

이 파일을 계속 “수동 memo 예외”로 둘지, feedback만 예외적으로 useCallback을 허용할지
missing_regression_test를 테스트 추가로 풀지, test-exception-approved로 예외할지
compiler 경고가 다시 늘면 이 PR을 닫고 의존성 주석만 보강하는 편이 나을지

너의 추천
지금 상태로는 머지하지 마세요. hygiene(missing_regression_test)를 먼저 풀고, bun run lint / react-compiler 경고가 HEAD 주석과 모순되지 않는지 로그를 PR에 붙이세요. 경고가 늘면 close-don't-rebase가 맞습니다. toast 조기 dismiss 버그가 재현되면 그 재현 테스트를 핵심으로 다시 열면 됩니다.

이 댓글은 grok-bot이 작성했습니다

#3984 added its review screenshot under a new assets/pr-screenshots/ directory. The repository's nineteen existing PR screenshots all live in docs-site/public/pr-screenshots/, so this moves it there and keeps the new top-level directory out of the tree. Co-authored-by: yansigit <44089734+yansigit@users.noreply.github.com>

…lback test (#4053) * test(cli): make stale-port status fixture deterministic Carried from #3980 (author yansigit) for maintainer-side CI and sequential integration. Co-authored-by: yansigit <44089734+yansigit@users.noreply.github.com> * refactor(router): isolate API-key selection capture Carried from #3897 (author parkjs101) for maintainer-side CI and sequential integration. Closes #3894 Co-authored-by: parkjs101 <93533648+parkjs101@users.noreply.github.com> * docs: retire the historical dashboard capture pack Carried from #3963 (author luvs01) for maintainer-side CI and sequential integration. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * refactor(gui): stabilize model feedback callback dependencies Carried from #3984 (author yansigit) for maintainer-side CI and sequential integration. Co-authored-by: yansigit <44089734+yansigit@users.noreply.github.com> * test(gui): pin the publishFeedback callback identity #3984 changes publishFeedback to a useCallback and adds it to saveDisplayName's dependency array, but shipped without coverage, so the hygiene gate flags missing_regression_test. This source-oracle test asserts both halves and fails on dev without the fix (0 pass / 2 fail), so the suppression cannot come back unnoticed. Co-authored-by: yansigit <44089734+yansigit@users.noreply.github.com> * chore(assets): file the #3984 screenshot with the others #3984 added its review screenshot under a new assets/pr-screenshots/ directory. The repository's nineteen existing PR screenshots all live in docs-site/public/pr-screenshots/, so this moves it there and keeps the new top-level directory out of the tree. Co-authored-by: yansigit <44089734+yansigit@users.noreply.github.com> --------- Co-authored-by: t <a@b.com> Co-authored-by: yansigit <44089734+yansigit@users.noreply.github.com> Co-authored-by: parkjs101 <93533648+parkjs101@users.noreply.github.com> Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com>

lidge-jun · 2026-09-08T19:13:47Z

Landed on dev in 164bd2b via #4053, which carried four reviewed changes as one sequential integration branch. Your commit is preserved in the squash body with a Co-authored-by trailer, so the contribution stays attributed to you.

Verification at the merged head e52116316: Cross-platform CI run 34265891731 finished with 19 jobs successful and 0 failures, bun x tsc --noEmit exit 0, and the changed test files pass. An independent review confirmed the stacked tree is byte-identical to the union of the carried diffs.

Closing this PR because the change is already on dev. Thank you.

Two notes specific to this one. The hygiene gate flagged missing_regression_test, so the carry adds tests/gui/models-feedback-callback.test.ts, which asserts both halves of your fix and fails on dev without it (0 pass / 2 fail). Your review screenshot moved from assets/pr-screenshots/ to docs-site/public/pr-screenshots/3984-model-feedback.png, where the repository's other nineteen live.

lidge-jun · 2026-09-08T19:18:28Z

Landed via #4053 at 164bd2b

refactor(gui): stabilize model feedback callback dependencies

35a4d99

Extracted and adapted from fork commit 4d36c91. Co-authored-by: Yumi <automation@sbyoon.com>

github-actions Bot added chore Maintenance, CI, tests, refactors, or build changes (not a user-facing bug or feature). intake: hygiene-blocked Deterministic PR hygiene checks failed labels Sep 8, 2026

lidge-jun mentioned this pull request Sep 8, 2026

wp3: land four small contributor changes and the missing feedback-callback test #4053

Merged

3 tasks

lidge-jun closed this Sep 8, 2026

lidge-jun added the landed-via-maintainer Original PR closed after landing via a maintainer merge train label Sep 8, 2026

Navigation Menu

refactor(gui): stabilize model feedback callback dependencies - #3984

refactor(gui): stabilize model feedback callback dependencies#3984
yansigit wants to merge 1 commit into
lidge-jun:devfrom
yansigit:codex/upstream-model-feedback-20260908

yansigit commented Sep 8, 2026 •

edited by github-actions Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 8, 2026

Draft PR not reviewed

Uh oh!

github-actions Bot commented Sep 8, 2026

Uh oh!

github-actions Bot commented Sep 8, 2026 •

edited

Loading

Uh oh!

lidge-jun commented Sep 8, 2026

Uh oh!

lidge-jun commented Sep 8, 2026

Uh oh!

lidge-jun commented Sep 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

yansigit commented Sep 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Checklist

Review readiness

Review readiness checklist

Uh oh!

coderabbitai Bot commented Sep 8, 2026

Draft PR not reviewed

Uh oh!

github-actions Bot commented Sep 8, 2026

Uh oh!

github-actions Bot commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⏳ DRAFT

What to do

Review readiness checklist

Hygiene

Uh oh!

lidge-jun commented Sep 8, 2026

리뷰 · 우선순위 36 / 80

Uh oh!

lidge-jun commented Sep 8, 2026

Uh oh!

lidge-jun commented Sep 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yansigit commented Sep 8, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Sep 8, 2026 •

edited

Loading